[NFC][DI]: remove getLivenessAtNonTupleInst method from definite init #85430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method originally special-cased logic that would provide a meaningful speedup and simplification, but IIUC the history, this has no longer been the case for many years, so we might as well remove it to make the code more straightforward.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
thanks for reviewing @eeckstein – please merge when you get a chance! |
Contributor
Author
|
@eeckstein ping to merge this when you can please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method originally special-cased logic that would provide a meaningful speedup and simplification, but if I've followed the history correctly, this has no longer been the case for many years, so we might as well remove it to make the code slightly more straightforward.
History:
isLiveOut1method.getLiveOut1etc in c3907b3) removed when exponential complexity was fixed in 12b43dd.